-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test CheckForServiceAvailability #25
Conversation
Add a unit test too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downtime notifications are a nice feature. Did this already exist before? I never knew to update the availability status.
I'm not sure that storing the file in the main branch is the best way to go. This feels like mixing code with devops, although it's temptingly straightforward.
Thanks for the tests!
Yes this was already there, I just cleaned the code and changed paths to Github. Where would you store the yml file? |
Maybe a separate branch? Let's merge this as is and discuss next week. |
I have the feeling as well this is added complexity for no real reason. A better way to do this, IMHO, would be to make the BE return the unaivalabiltity and log it here (or maybe just simply notify the users). TBH I would get rid of this logic, but indeed we can do in another PR. Something else though. I think this requires the file |
Sorry I don't see what file you're talking about. It checks the service availability from |
yes, that one. Ah ok I see it now on github. I got confused by this and was looking for it in the release |
Ok then I'll merge this one and later we can talk about hosting the yml file on a different branch. |
Will close #23
Tag the repo with in increased path version after merging this.